feat(frontend): Enhance Story form with acceptance criteria, assignee, tags, and story points - Sprint 4 Story 3
Enhanced the Story creation and editing form with 4 new UX-designed fields to improve Story planning capabilities and align with comprehensive UX specifications. New Features: 1. **Acceptance Criteria Editor**: Dynamic checkbox list for defining completion conditions - Add/remove criteria with Enter key - Inline editing with visual checkboxes - Empty state handling 2. **Assignee Selector**: Dropdown for team member assignment - Shows current user by default - Unassigned option available - Ready for future user list integration 3. **Tags Input**: Multi-select tags for categorization - Add tags with Enter key - Remove with Backspace or X button - Lowercase normalization for consistency 4. **Story Points**: Numeric field for estimation - Accepts 0-100 range (Fibonacci scale suggested) - Optional field with validation - Integer-only input Components Created: - components/projects/acceptance-criteria-editor.tsx (92 lines) - components/projects/tags-input.tsx (70 lines) Files Modified: - components/projects/story-form.tsx: Added 4 new form fields (410 lines total) - types/project.ts: Updated Story/CreateStoryDto/UpdateStoryDto interfaces Technical Implementation: - Zod schema validation for all new fields - Backward compatible (all fields optional) - Form default values from existing Story data - TypeScript type safety throughout - shadcn/ui component consistency - Responsive two-column layout - Clear field descriptions and placeholders Validation Rules: - Acceptance criteria: Array of strings (default: []) - Assignee ID: Optional string - Tags: Array of strings (default: [], lowercase) - Story points: Optional number (0-100 range) Testing: - Frontend compilation: ✅ No errors - Type checking: ✅ All types valid - Form submission: Create and Update operations both supported - Backward compatibility: Existing Stories work without new fields Sprint 4 Story 3 Status: COMPLETE ✅ All acceptance criteria met: ✅ Form includes all 4 new fields ✅ Acceptance criteria can be added/removed dynamically ✅ Tags support multi-select ✅ Assignee selector shows user list (current user) ✅ Story Points accepts 0-100 integers ✅ Form validation works for all fields ✅ Backward compatible with existing Stories ✅ No TypeScript errors ✅ Frontend compiles successfully 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
@@ -28,6 +28,8 @@ import type { Story, WorkItemPriority } from '@/types/project';
|
||||
import { toast } from 'sonner';
|
||||
import { Loader2 } from 'lucide-react';
|
||||
import { useAuthStore } from '@/stores/authStore';
|
||||
import { AcceptanceCriteriaEditor } from './acceptance-criteria-editor';
|
||||
import { TagsInput } from './tags-input';
|
||||
|
||||
const storySchema = z.object({
|
||||
epicId: z.string().min(1, 'Parent Epic is required'),
|
||||
@@ -45,6 +47,16 @@ const storySchema = z.object({
|
||||
.min(0, 'Estimated hours must be positive')
|
||||
.optional()
|
||||
.or(z.literal('')),
|
||||
// Sprint 4 Story 3: New fields
|
||||
acceptanceCriteria: z.array(z.string()).default([]),
|
||||
assigneeId: z.string().optional(),
|
||||
tags: z.array(z.string()).default([]),
|
||||
storyPoints: z
|
||||
.number()
|
||||
.min(0, 'Story points must be positive')
|
||||
.max(100, 'Story points must be less than 100')
|
||||
.optional()
|
||||
.or(z.literal('')),
|
||||
});
|
||||
|
||||
type StoryFormValues = z.infer<typeof storySchema>;
|
||||
@@ -80,6 +92,11 @@ export function StoryForm({
|
||||
description: story?.description || '',
|
||||
priority: story?.priority || 'Medium',
|
||||
estimatedHours: story?.estimatedHours || ('' as any),
|
||||
// Sprint 4 Story 3: New field defaults
|
||||
acceptanceCriteria: story?.acceptanceCriteria || [],
|
||||
assigneeId: story?.assigneeId || '',
|
||||
tags: story?.tags || [],
|
||||
storyPoints: story?.storyPoints || ('' as any),
|
||||
},
|
||||
});
|
||||
|
||||
@@ -94,6 +111,12 @@ export function StoryForm({
|
||||
priority: data.priority,
|
||||
estimatedHours:
|
||||
typeof data.estimatedHours === 'number' ? data.estimatedHours : undefined,
|
||||
// Sprint 4 Story 3: New fields
|
||||
acceptanceCriteria: data.acceptanceCriteria,
|
||||
assigneeId: data.assigneeId || undefined,
|
||||
tags: data.tags,
|
||||
storyPoints:
|
||||
typeof data.storyPoints === 'number' ? data.storyPoints : undefined,
|
||||
},
|
||||
});
|
||||
toast.success('Story updated successfully');
|
||||
@@ -115,6 +138,12 @@ export function StoryForm({
|
||||
estimatedHours:
|
||||
typeof data.estimatedHours === 'number' ? data.estimatedHours : undefined,
|
||||
createdBy: user.id,
|
||||
// Sprint 4 Story 3: New fields
|
||||
acceptanceCriteria: data.acceptanceCriteria,
|
||||
assigneeId: data.assigneeId || undefined,
|
||||
tags: data.tags,
|
||||
storyPoints:
|
||||
typeof data.storyPoints === 'number' ? data.storyPoints : undefined,
|
||||
});
|
||||
toast.success('Story created successfully');
|
||||
}
|
||||
@@ -259,6 +288,111 @@ export function StoryForm({
|
||||
/>
|
||||
</div>
|
||||
|
||||
{/* Sprint 4 Story 3: Acceptance Criteria */}
|
||||
<FormField
|
||||
control={form.control}
|
||||
name="acceptanceCriteria"
|
||||
render={({ field }) => (
|
||||
<FormItem>
|
||||
<FormLabel>Acceptance Criteria</FormLabel>
|
||||
<FormControl>
|
||||
<AcceptanceCriteriaEditor
|
||||
criteria={field.value}
|
||||
onChange={field.onChange}
|
||||
disabled={isLoading}
|
||||
/>
|
||||
</FormControl>
|
||||
<FormDescription>
|
||||
Define conditions that must be met for this story to be complete
|
||||
</FormDescription>
|
||||
<FormMessage />
|
||||
</FormItem>
|
||||
)}
|
||||
/>
|
||||
|
||||
{/* Sprint 4 Story 3: Assignee and Story Points */}
|
||||
<div className="grid grid-cols-2 gap-4">
|
||||
<FormField
|
||||
control={form.control}
|
||||
name="assigneeId"
|
||||
render={({ field }) => (
|
||||
<FormItem>
|
||||
<FormLabel>Assignee</FormLabel>
|
||||
<Select
|
||||
onValueChange={field.onChange}
|
||||
value={field.value}
|
||||
disabled={isLoading}
|
||||
>
|
||||
<FormControl>
|
||||
<SelectTrigger>
|
||||
<SelectValue placeholder="Unassigned" />
|
||||
</SelectTrigger>
|
||||
</FormControl>
|
||||
<SelectContent>
|
||||
<SelectItem value="">Unassigned</SelectItem>
|
||||
{user?.id && (
|
||||
<SelectItem value={user.id}>{user.fullName || 'Me'}</SelectItem>
|
||||
)}
|
||||
</SelectContent>
|
||||
</Select>
|
||||
<FormDescription>Assign to team member</FormDescription>
|
||||
<FormMessage />
|
||||
</FormItem>
|
||||
)}
|
||||
/>
|
||||
|
||||
<FormField
|
||||
control={form.control}
|
||||
name="storyPoints"
|
||||
render={({ field }) => (
|
||||
<FormItem>
|
||||
<FormLabel>Story Points</FormLabel>
|
||||
<FormControl>
|
||||
<Input
|
||||
type="number"
|
||||
placeholder="e.g., 5"
|
||||
min="0"
|
||||
max="100"
|
||||
step="1"
|
||||
{...field}
|
||||
onChange={(e) => {
|
||||
const value = e.target.value;
|
||||
field.onChange(value === '' ? '' : parseInt(value));
|
||||
}}
|
||||
value={field.value === undefined ? '' : field.value}
|
||||
disabled={isLoading}
|
||||
/>
|
||||
</FormControl>
|
||||
<FormDescription>Fibonacci: 1, 2, 3, 5, 8, 13...</FormDescription>
|
||||
<FormMessage />
|
||||
</FormItem>
|
||||
)}
|
||||
/>
|
||||
</div>
|
||||
|
||||
{/* Sprint 4 Story 3: Tags */}
|
||||
<FormField
|
||||
control={form.control}
|
||||
name="tags"
|
||||
render={({ field }) => (
|
||||
<FormItem>
|
||||
<FormLabel>Tags</FormLabel>
|
||||
<FormControl>
|
||||
<TagsInput
|
||||
tags={field.value}
|
||||
onChange={field.onChange}
|
||||
disabled={isLoading}
|
||||
placeholder="Add tags (press Enter)..."
|
||||
/>
|
||||
</FormControl>
|
||||
<FormDescription>
|
||||
Add tags to categorize this story (e.g., frontend, bug, urgent)
|
||||
</FormDescription>
|
||||
<FormMessage />
|
||||
</FormItem>
|
||||
)}
|
||||
/>
|
||||
|
||||
<div className="flex justify-end gap-3">
|
||||
{onCancel && (
|
||||
<Button
|
||||
|
||||
Reference in New Issue
Block a user