fix(frontend): Fix critical type safety issues from code review
Address all Critical and High Priority issues identified in frontend code review report: Critical Issues Fixed: - Created unified logger utility (lib/utils/logger.ts) to replace all console.log statements - Consolidated User type definitions - removed duplicate from authStore, using single source from types/user.ts - Eliminated 'any' types in API client - added proper generic types with AxiosRequestConfig - Fixed SignalR ConnectionManager - replaced 'any' with generic types <T> - Created API error types (lib/types/errors.ts) with ApiError and getErrorMessage helper - Fixed IssueCard component - removed all type assertions, created discriminated union types for Kanban items - Added React.memo to IssueCard for performance optimization - Added proper ARIA labels and accessibility attributes to IssueCard High Priority Issues Fixed: - Fixed hardcoded user ID in CreateProjectDialog - now uses actual user from authStore - Added useCallback to CreateProjectDialog onSubmit handler - Fixed error handlers in use-epics.ts - replaced 'any' with ApiError type - Updated all error handling to use logger and getErrorMessage Type Safety Improvements: - Created KanbanItem discriminated union (KanbanEpic | KanbanStory | KanbanTask) with proper type guards - Added 'never' types to prevent invalid property access - Fixed User interface to include all required fields (createdAt, updatedAt) - Maintained backward compatibility with LegacyKanbanBoard for existing code Files Changed: - lib/utils/logger.ts - New centralized logging utility - lib/types/errors.ts - New API error types and helpers - types/user.ts - Consolidated User type with TenantRole - types/kanban.ts - New discriminated union types for type-safe Kanban items - components/features/kanban/IssueCard.tsx - Type-safe with React.memo - components/features/projects/CreateProjectDialog.tsx - Fixed hardcoded user ID, added useCallback - lib/api/client.ts - Eliminated 'any', added proper generics - lib/signalr/ConnectionManager.ts - Replaced console.log, added generics - lib/hooks/use-epics.ts - Fixed error handler types - stores/authStore.ts - Removed duplicate User type - lib/hooks/useAuth.ts - Added createdAt field to User TypeScript compilation: ✅ All type checks passing (0 errors) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
@@ -1,5 +1,6 @@
|
||||
'use client';
|
||||
|
||||
import { useCallback } from 'react';
|
||||
import { useForm } from 'react-hook-form';
|
||||
import { zodResolver } from '@hookform/resolvers/zod';
|
||||
import * as z from 'zod';
|
||||
@@ -23,6 +24,9 @@ import {
|
||||
import { Input } from '@/components/ui/input';
|
||||
import { Button } from '@/components/ui/button';
|
||||
import { useCreateProject } from '@/lib/hooks/use-projects';
|
||||
import { useAuthStore } from '@/stores/authStore';
|
||||
import { toast } from 'sonner';
|
||||
import { logger } from '@/lib/utils/logger';
|
||||
import type { CreateProjectDto } from '@/types/project';
|
||||
|
||||
const projectSchema = z.object({
|
||||
@@ -45,6 +49,7 @@ export function CreateProjectDialog({
|
||||
onOpenChange,
|
||||
}: CreateProjectDialogProps) {
|
||||
const createProject = useCreateProject();
|
||||
const user = useAuthStore((state) => state.user);
|
||||
|
||||
const form = useForm<CreateProjectDto>({
|
||||
resolver: zodResolver(projectSchema),
|
||||
@@ -55,20 +60,34 @@ export function CreateProjectDialog({
|
||||
},
|
||||
});
|
||||
|
||||
const onSubmit = async (data: CreateProjectDto) => {
|
||||
try {
|
||||
// TODO: Replace with actual user ID from auth context
|
||||
const projectData = {
|
||||
...data,
|
||||
ownerId: '00000000-0000-0000-0000-000000000001',
|
||||
};
|
||||
await createProject.mutateAsync(projectData);
|
||||
form.reset();
|
||||
onOpenChange(false);
|
||||
} catch (error) {
|
||||
console.error('Failed to create project:', error);
|
||||
}
|
||||
};
|
||||
const onSubmit = useCallback(
|
||||
async (data: CreateProjectDto) => {
|
||||
// Validate user is logged in
|
||||
if (!user) {
|
||||
toast.error('You must be logged in to create a project');
|
||||
logger.error('Attempted to create project without authentication');
|
||||
return;
|
||||
}
|
||||
|
||||
try {
|
||||
const projectData = {
|
||||
...data,
|
||||
ownerId: user.id,
|
||||
};
|
||||
|
||||
logger.debug('Creating project', projectData);
|
||||
await createProject.mutateAsync(projectData);
|
||||
|
||||
form.reset();
|
||||
onOpenChange(false);
|
||||
toast.success('Project created successfully');
|
||||
} catch (error) {
|
||||
logger.error('Failed to create project', error);
|
||||
toast.error('Failed to create project. Please try again.');
|
||||
}
|
||||
},
|
||||
[createProject, form, onOpenChange, user]
|
||||
);
|
||||
|
||||
return (
|
||||
<Dialog open={open} onOpenChange={onOpenChange}>
|
||||
|
||||
Reference in New Issue
Block a user