fix(frontend): Fix critical type safety issues from code review
Address all Critical and High Priority issues identified in frontend code review report: Critical Issues Fixed: - Created unified logger utility (lib/utils/logger.ts) to replace all console.log statements - Consolidated User type definitions - removed duplicate from authStore, using single source from types/user.ts - Eliminated 'any' types in API client - added proper generic types with AxiosRequestConfig - Fixed SignalR ConnectionManager - replaced 'any' with generic types <T> - Created API error types (lib/types/errors.ts) with ApiError and getErrorMessage helper - Fixed IssueCard component - removed all type assertions, created discriminated union types for Kanban items - Added React.memo to IssueCard for performance optimization - Added proper ARIA labels and accessibility attributes to IssueCard High Priority Issues Fixed: - Fixed hardcoded user ID in CreateProjectDialog - now uses actual user from authStore - Added useCallback to CreateProjectDialog onSubmit handler - Fixed error handlers in use-epics.ts - replaced 'any' with ApiError type - Updated all error handling to use logger and getErrorMessage Type Safety Improvements: - Created KanbanItem discriminated union (KanbanEpic | KanbanStory | KanbanTask) with proper type guards - Added 'never' types to prevent invalid property access - Fixed User interface to include all required fields (createdAt, updatedAt) - Maintained backward compatibility with LegacyKanbanBoard for existing code Files Changed: - lib/utils/logger.ts - New centralized logging utility - lib/types/errors.ts - New API error types and helpers - types/user.ts - Consolidated User type with TenantRole - types/kanban.ts - New discriminated union types for type-safe Kanban items - components/features/kanban/IssueCard.tsx - Type-safe with React.memo - components/features/projects/CreateProjectDialog.tsx - Fixed hardcoded user ID, added useCallback - lib/api/client.ts - Eliminated 'any', added proper generics - lib/signalr/ConnectionManager.ts - Replaced console.log, added generics - lib/hooks/use-epics.ts - Fixed error handler types - stores/authStore.ts - Removed duplicate User type - lib/hooks/useAuth.ts - Added createdAt field to User TypeScript compilation: ✅ All type checks passing (0 errors) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
@@ -1,5 +1,6 @@
|
||||
import axios, { AxiosError, InternalAxiosRequestConfig } from 'axios';
|
||||
import axios, { AxiosError, AxiosRequestConfig, InternalAxiosRequestConfig } from 'axios';
|
||||
import { API_BASE_URL } from './config';
|
||||
import { logger } from '@/lib/utils/logger';
|
||||
|
||||
// Create axios instance
|
||||
export const apiClient = axios.create({
|
||||
@@ -134,30 +135,42 @@ apiClient.interceptors.response.use(
|
||||
}
|
||||
);
|
||||
|
||||
// API helper functions
|
||||
// API helper functions with proper typing
|
||||
export const api = {
|
||||
get: async <T>(url: string, config?: any): Promise<T> => {
|
||||
const response = await apiClient.get(url, config);
|
||||
get: async <T>(url: string, config?: AxiosRequestConfig): Promise<T> => {
|
||||
const response = await apiClient.get<T>(url, config);
|
||||
return response.data;
|
||||
},
|
||||
|
||||
post: async <T>(url: string, data?: any, config?: any): Promise<T> => {
|
||||
const response = await apiClient.post(url, data, config);
|
||||
post: async <T, D = unknown>(
|
||||
url: string,
|
||||
data?: D,
|
||||
config?: AxiosRequestConfig
|
||||
): Promise<T> => {
|
||||
const response = await apiClient.post<T>(url, data, config);
|
||||
return response.data;
|
||||
},
|
||||
|
||||
put: async <T>(url: string, data?: any, config?: any): Promise<T> => {
|
||||
const response = await apiClient.put(url, data, config);
|
||||
put: async <T, D = unknown>(
|
||||
url: string,
|
||||
data?: D,
|
||||
config?: AxiosRequestConfig
|
||||
): Promise<T> => {
|
||||
const response = await apiClient.put<T>(url, data, config);
|
||||
return response.data;
|
||||
},
|
||||
|
||||
patch: async <T>(url: string, data?: any, config?: any): Promise<T> => {
|
||||
const response = await apiClient.patch(url, data, config);
|
||||
patch: async <T, D = unknown>(
|
||||
url: string,
|
||||
data?: D,
|
||||
config?: AxiosRequestConfig
|
||||
): Promise<T> => {
|
||||
const response = await apiClient.patch<T>(url, data, config);
|
||||
return response.data;
|
||||
},
|
||||
|
||||
delete: async <T>(url: string, config?: any): Promise<T> => {
|
||||
const response = await apiClient.delete(url, config);
|
||||
delete: async <T>(url: string, config?: AxiosRequestConfig): Promise<T> => {
|
||||
const response = await apiClient.delete<T>(url, config);
|
||||
return response.data;
|
||||
},
|
||||
};
|
||||
|
||||
Reference in New Issue
Block a user