Address all Critical and High Priority issues identified in frontend code review report: Critical Issues Fixed: - Created unified logger utility (lib/utils/logger.ts) to replace all console.log statements - Consolidated User type definitions - removed duplicate from authStore, using single source from types/user.ts - Eliminated 'any' types in API client - added proper generic types with AxiosRequestConfig - Fixed SignalR ConnectionManager - replaced 'any' with generic types <T> - Created API error types (lib/types/errors.ts) with ApiError and getErrorMessage helper - Fixed IssueCard component - removed all type assertions, created discriminated union types for Kanban items - Added React.memo to IssueCard for performance optimization - Added proper ARIA labels and accessibility attributes to IssueCard High Priority Issues Fixed: - Fixed hardcoded user ID in CreateProjectDialog - now uses actual user from authStore - Added useCallback to CreateProjectDialog onSubmit handler - Fixed error handlers in use-epics.ts - replaced 'any' with ApiError type - Updated all error handling to use logger and getErrorMessage Type Safety Improvements: - Created KanbanItem discriminated union (KanbanEpic | KanbanStory | KanbanTask) with proper type guards - Added 'never' types to prevent invalid property access - Fixed User interface to include all required fields (createdAt, updatedAt) - Maintained backward compatibility with LegacyKanbanBoard for existing code Files Changed: - lib/utils/logger.ts - New centralized logging utility - lib/types/errors.ts - New API error types and helpers - types/user.ts - Consolidated User type with TenantRole - types/kanban.ts - New discriminated union types for type-safe Kanban items - components/features/kanban/IssueCard.tsx - Type-safe with React.memo - components/features/projects/CreateProjectDialog.tsx - Fixed hardcoded user ID, added useCallback - lib/api/client.ts - Eliminated 'any', added proper generics - lib/signalr/ConnectionManager.ts - Replaced console.log, added generics - lib/hooks/use-epics.ts - Fixed error handler types - stores/authStore.ts - Removed duplicate User type - lib/hooks/useAuth.ts - Added createdAt field to User TypeScript compilation: ✅ All type checks passing (0 errors) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
282 lines
8.6 KiB
TypeScript
282 lines
8.6 KiB
TypeScript
'use client';
|
|
|
|
import { useForm } from 'react-hook-form';
|
|
import { zodResolver } from '@hookform/resolvers/zod';
|
|
import * as z from 'zod';
|
|
import { Button } from '@/components/ui/button';
|
|
import {
|
|
Form,
|
|
FormControl,
|
|
FormDescription,
|
|
FormField,
|
|
FormItem,
|
|
FormLabel,
|
|
FormMessage,
|
|
} from '@/components/ui/form';
|
|
import { Input } from '@/components/ui/input';
|
|
import { Textarea } from '@/components/ui/textarea';
|
|
import {
|
|
Select,
|
|
SelectContent,
|
|
SelectItem,
|
|
SelectTrigger,
|
|
SelectValue,
|
|
} from '@/components/ui/select';
|
|
import { useCreateStory, useUpdateStory } from '@/lib/hooks/use-stories';
|
|
import { useEpics } from '@/lib/hooks/use-epics';
|
|
import type { Story, WorkItemPriority } from '@/types/project';
|
|
import { toast } from 'sonner';
|
|
import { Loader2 } from 'lucide-react';
|
|
import { useAuthStore } from '@/stores/authStore';
|
|
|
|
const storySchema = z.object({
|
|
epicId: z.string().min(1, 'Parent Epic is required'),
|
|
title: z
|
|
.string()
|
|
.min(1, 'Title is required')
|
|
.max(200, 'Title must be less than 200 characters'),
|
|
description: z
|
|
.string()
|
|
.max(2000, 'Description must be less than 2000 characters')
|
|
.optional(),
|
|
priority: z.enum(['Low', 'Medium', 'High', 'Critical']),
|
|
estimatedHours: z
|
|
.number()
|
|
.min(0, 'Estimated hours must be positive')
|
|
.optional()
|
|
.or(z.literal('')),
|
|
});
|
|
|
|
type StoryFormValues = z.infer<typeof storySchema>;
|
|
|
|
interface StoryFormProps {
|
|
story?: Story;
|
|
epicId?: string;
|
|
projectId?: string;
|
|
onSuccess?: () => void;
|
|
onCancel?: () => void;
|
|
}
|
|
|
|
export function StoryForm({
|
|
story,
|
|
epicId,
|
|
projectId,
|
|
onSuccess,
|
|
onCancel,
|
|
}: StoryFormProps) {
|
|
const isEditing = !!story;
|
|
const user = useAuthStore((state) => state.user);
|
|
const createStory = useCreateStory();
|
|
const updateStory = useUpdateStory();
|
|
|
|
// Fetch epics for parent epic selection
|
|
const { data: epics = [], isLoading: epicsLoading } = useEpics(projectId);
|
|
|
|
const form = useForm<StoryFormValues>({
|
|
resolver: zodResolver(storySchema),
|
|
defaultValues: {
|
|
epicId: story?.epicId || epicId || '',
|
|
title: story?.title || '',
|
|
description: story?.description || '',
|
|
priority: story?.priority || 'Medium',
|
|
estimatedHours: story?.estimatedHours || ('' as any),
|
|
},
|
|
});
|
|
|
|
async function onSubmit(data: StoryFormValues) {
|
|
try {
|
|
if (isEditing && story) {
|
|
await updateStory.mutateAsync({
|
|
id: story.id,
|
|
data: {
|
|
title: data.title,
|
|
description: data.description,
|
|
priority: data.priority,
|
|
estimatedHours:
|
|
typeof data.estimatedHours === 'number' ? data.estimatedHours : undefined,
|
|
},
|
|
});
|
|
toast.success('Story updated successfully');
|
|
} else {
|
|
if (!user?.id) {
|
|
toast.error('User not authenticated');
|
|
return;
|
|
}
|
|
if (!projectId) {
|
|
toast.error('Project ID is required');
|
|
return;
|
|
}
|
|
await createStory.mutateAsync({
|
|
epicId: data.epicId,
|
|
projectId,
|
|
title: data.title,
|
|
description: data.description,
|
|
priority: data.priority,
|
|
estimatedHours:
|
|
typeof data.estimatedHours === 'number' ? data.estimatedHours : undefined,
|
|
createdBy: user.id,
|
|
});
|
|
toast.success('Story created successfully');
|
|
}
|
|
onSuccess?.();
|
|
} catch (error) {
|
|
const message = error instanceof Error ? error.message : 'Operation failed';
|
|
toast.error(message);
|
|
}
|
|
}
|
|
|
|
const isLoading = createStory.isPending || updateStory.isPending;
|
|
|
|
return (
|
|
<Form {...form}>
|
|
<form onSubmit={form.handleSubmit(onSubmit)} className="space-y-6">
|
|
<FormField
|
|
control={form.control}
|
|
name="epicId"
|
|
render={({ field }) => (
|
|
<FormItem>
|
|
<FormLabel>Parent Epic *</FormLabel>
|
|
<Select
|
|
onValueChange={field.onChange}
|
|
defaultValue={field.value}
|
|
disabled={isEditing || !!epicId}
|
|
>
|
|
<FormControl>
|
|
<SelectTrigger>
|
|
<SelectValue placeholder="Select parent epic" />
|
|
</SelectTrigger>
|
|
</FormControl>
|
|
<SelectContent>
|
|
{epicsLoading ? (
|
|
<div className="p-2 text-sm text-muted-foreground">Loading epics...</div>
|
|
) : epics.length === 0 ? (
|
|
<div className="p-2 text-sm text-muted-foreground">
|
|
No epics available
|
|
</div>
|
|
) : (
|
|
epics.map((epic) => (
|
|
<SelectItem key={epic.id} value={epic.id}>
|
|
{epic.name}
|
|
</SelectItem>
|
|
))
|
|
)}
|
|
</SelectContent>
|
|
</Select>
|
|
<FormDescription>
|
|
{isEditing ? 'Parent epic cannot be changed' : 'Select the parent epic'}
|
|
</FormDescription>
|
|
<FormMessage />
|
|
</FormItem>
|
|
)}
|
|
/>
|
|
|
|
<FormField
|
|
control={form.control}
|
|
name="title"
|
|
render={({ field }) => (
|
|
<FormItem>
|
|
<FormLabel>Story Title *</FormLabel>
|
|
<FormControl>
|
|
<Input placeholder="e.g., Login page with OAuth support" {...field} />
|
|
</FormControl>
|
|
<FormDescription>A clear, concise title for this story</FormDescription>
|
|
<FormMessage />
|
|
</FormItem>
|
|
)}
|
|
/>
|
|
|
|
<FormField
|
|
control={form.control}
|
|
name="description"
|
|
render={({ field }) => (
|
|
<FormItem>
|
|
<FormLabel>Description</FormLabel>
|
|
<FormControl>
|
|
<Textarea
|
|
placeholder="Detailed description of the story..."
|
|
className="resize-none"
|
|
rows={6}
|
|
{...field}
|
|
/>
|
|
</FormControl>
|
|
<FormDescription>
|
|
Optional detailed description (max 2000 characters)
|
|
</FormDescription>
|
|
<FormMessage />
|
|
</FormItem>
|
|
)}
|
|
/>
|
|
|
|
<div className="grid grid-cols-2 gap-4">
|
|
<FormField
|
|
control={form.control}
|
|
name="priority"
|
|
render={({ field }) => (
|
|
<FormItem>
|
|
<FormLabel>Priority *</FormLabel>
|
|
<Select onValueChange={field.onChange} defaultValue={field.value}>
|
|
<FormControl>
|
|
<SelectTrigger>
|
|
<SelectValue placeholder="Select priority" />
|
|
</SelectTrigger>
|
|
</FormControl>
|
|
<SelectContent>
|
|
<SelectItem value="Low">Low</SelectItem>
|
|
<SelectItem value="Medium">Medium</SelectItem>
|
|
<SelectItem value="High">High</SelectItem>
|
|
<SelectItem value="Critical">Critical</SelectItem>
|
|
</SelectContent>
|
|
</Select>
|
|
<FormMessage />
|
|
</FormItem>
|
|
)}
|
|
/>
|
|
|
|
<FormField
|
|
control={form.control}
|
|
name="estimatedHours"
|
|
render={({ field }) => (
|
|
<FormItem>
|
|
<FormLabel>Estimated Hours</FormLabel>
|
|
<FormControl>
|
|
<Input
|
|
type="number"
|
|
placeholder="e.g., 8"
|
|
min="0"
|
|
step="0.5"
|
|
{...field}
|
|
onChange={(e) => {
|
|
const value = e.target.value;
|
|
field.onChange(value === '' ? '' : parseFloat(value));
|
|
}}
|
|
value={field.value === undefined ? '' : field.value}
|
|
/>
|
|
</FormControl>
|
|
<FormDescription>Optional time estimate</FormDescription>
|
|
<FormMessage />
|
|
</FormItem>
|
|
)}
|
|
/>
|
|
</div>
|
|
|
|
<div className="flex justify-end gap-3">
|
|
{onCancel && (
|
|
<Button
|
|
type="button"
|
|
variant="outline"
|
|
onClick={onCancel}
|
|
disabled={isLoading}
|
|
>
|
|
Cancel
|
|
</Button>
|
|
)}
|
|
<Button type="submit" disabled={isLoading}>
|
|
{isLoading && <Loader2 className="mr-2 h-4 w-4 animate-spin" />}
|
|
{isEditing ? 'Update Story' : 'Create Story'}
|
|
</Button>
|
|
</div>
|
|
</form>
|
|
</Form>
|
|
);
|
|
}
|