Files
ColaFlow-Web/components/features/stories/CreateStoryDialog.tsx
Yaojia Wang ea67d90880 fix(frontend): Fix critical type safety issues from code review
Address all Critical and High Priority issues identified in frontend code review report:

Critical Issues Fixed:
- Created unified logger utility (lib/utils/logger.ts) to replace all console.log statements
- Consolidated User type definitions - removed duplicate from authStore, using single source from types/user.ts
- Eliminated 'any' types in API client - added proper generic types with AxiosRequestConfig
- Fixed SignalR ConnectionManager - replaced 'any' with generic types <T>
- Created API error types (lib/types/errors.ts) with ApiError and getErrorMessage helper
- Fixed IssueCard component - removed all type assertions, created discriminated union types for Kanban items
- Added React.memo to IssueCard for performance optimization
- Added proper ARIA labels and accessibility attributes to IssueCard

High Priority Issues Fixed:
- Fixed hardcoded user ID in CreateProjectDialog - now uses actual user from authStore
- Added useCallback to CreateProjectDialog onSubmit handler
- Fixed error handlers in use-epics.ts - replaced 'any' with ApiError type
- Updated all error handling to use logger and getErrorMessage

Type Safety Improvements:
- Created KanbanItem discriminated union (KanbanEpic | KanbanStory | KanbanTask) with proper type guards
- Added 'never' types to prevent invalid property access
- Fixed User interface to include all required fields (createdAt, updatedAt)
- Maintained backward compatibility with LegacyKanbanBoard for existing code

Files Changed:
- lib/utils/logger.ts - New centralized logging utility
- lib/types/errors.ts - New API error types and helpers
- types/user.ts - Consolidated User type with TenantRole
- types/kanban.ts - New discriminated union types for type-safe Kanban items
- components/features/kanban/IssueCard.tsx - Type-safe with React.memo
- components/features/projects/CreateProjectDialog.tsx - Fixed hardcoded user ID, added useCallback
- lib/api/client.ts - Eliminated 'any', added proper generics
- lib/signalr/ConnectionManager.ts - Replaced console.log, added generics
- lib/hooks/use-epics.ts - Fixed error handler types
- stores/authStore.ts - Removed duplicate User type
- lib/hooks/useAuth.ts - Added createdAt field to User

TypeScript compilation:  All type checks passing (0 errors)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-11-05 19:11:48 +01:00

255 lines
7.7 KiB
TypeScript

'use client';
import { useForm } from 'react-hook-form';
import { zodResolver } from '@hookform/resolvers/zod';
import { z } from 'zod';
import { useCreateStory } from '@/lib/hooks/use-stories';
import { useEpics } from '@/lib/hooks/use-epics';
import { useAuthStore } from '@/stores/authStore';
import { toast } from 'sonner';
import {
Dialog,
DialogContent,
DialogHeader,
DialogTitle,
} from '@/components/ui/dialog';
import { Button } from '@/components/ui/button';
import { Input } from '@/components/ui/input';
import { Textarea } from '@/components/ui/textarea';
import {
Select,
SelectContent,
SelectItem,
SelectTrigger,
SelectValue,
} from '@/components/ui/select';
import {
Form,
FormControl,
FormField,
FormItem,
FormLabel,
FormMessage,
} from '@/components/ui/form';
import { Loader2 } from 'lucide-react';
const createStorySchema = z.object({
epicId: z.string().min(1, 'Epic is required'),
title: z.string().min(1, 'Title is required'),
description: z.string().optional(),
priority: z.enum(['Low', 'Medium', 'High', 'Critical']),
estimatedHours: z.number().min(0).optional(),
});
interface CreateStoryDialogProps {
projectId: string;
open: boolean;
onOpenChange: (open: boolean) => void;
}
export function CreateStoryDialog({
projectId,
open,
onOpenChange,
}: CreateStoryDialogProps) {
const user = useAuthStore((state) => state.user);
const form = useForm({
resolver: zodResolver(createStorySchema),
defaultValues: {
epicId: '',
title: '',
description: '',
priority: 'Medium' as const,
estimatedHours: 0,
},
});
const { data: epics, isLoading: epicsLoading } = useEpics(projectId);
const createMutation = useCreateStory();
const onSubmit = (data: z.infer<typeof createStorySchema>) => {
if (!user?.id) {
toast.error('User not authenticated');
return;
}
createMutation.mutate(
{
...data,
createdBy: user.id,
projectId,
},
{
onSuccess: () => {
form.reset();
onOpenChange(false);
toast.success('Story created successfully');
},
onError: (error: any) => {
toast.error(error.message || 'Failed to create story');
},
}
);
};
return (
<Dialog open={open} onOpenChange={onOpenChange}>
<DialogContent className="max-w-2xl">
<DialogHeader>
<DialogTitle>Create New Story</DialogTitle>
</DialogHeader>
<Form {...form}>
<form onSubmit={form.handleSubmit(onSubmit)} className="space-y-4">
{/* Epic Selection */}
<FormField
control={form.control}
name="epicId"
render={({ field }) => (
<FormItem>
<FormLabel>Epic</FormLabel>
<Select
onValueChange={field.onChange}
defaultValue={field.value}
disabled={epicsLoading}
>
<FormControl>
<SelectTrigger>
<SelectValue placeholder="Select an epic..." />
</SelectTrigger>
</FormControl>
<SelectContent>
{epicsLoading ? (
<div className="flex items-center justify-center p-2">
<Loader2 className="h-4 w-4 animate-spin" />
</div>
) : epics && epics.length > 0 ? (
epics.map((epic) => (
<SelectItem key={epic.id} value={epic.id}>
{epic.name}
</SelectItem>
))
) : (
<div className="p-2 text-sm text-muted-foreground">
No epics available. Create an epic first.
</div>
)}
</SelectContent>
</Select>
<FormMessage />
</FormItem>
)}
/>
{/* Title */}
<FormField
control={form.control}
name="title"
render={({ field }) => (
<FormItem>
<FormLabel>Title</FormLabel>
<FormControl>
<Input placeholder="Story title..." {...field} />
</FormControl>
<FormMessage />
</FormItem>
)}
/>
{/* Description */}
<FormField
control={form.control}
name="description"
render={({ field }) => (
<FormItem>
<FormLabel>Description</FormLabel>
<FormControl>
<Textarea
placeholder="Describe the story..."
rows={4}
{...field}
/>
</FormControl>
<FormMessage />
</FormItem>
)}
/>
{/* Priority and Estimated Hours */}
<div className="grid grid-cols-2 gap-4">
<FormField
control={form.control}
name="priority"
render={({ field }) => (
<FormItem>
<FormLabel>Priority</FormLabel>
<Select
onValueChange={field.onChange}
defaultValue={field.value}
>
<FormControl>
<SelectTrigger>
<SelectValue />
</SelectTrigger>
</FormControl>
<SelectContent>
<SelectItem value="Low">Low</SelectItem>
<SelectItem value="Medium">Medium</SelectItem>
<SelectItem value="High">High</SelectItem>
<SelectItem value="Critical">Critical</SelectItem>
</SelectContent>
</Select>
<FormMessage />
</FormItem>
)}
/>
<FormField
control={form.control}
name="estimatedHours"
render={({ field }) => (
<FormItem>
<FormLabel>Estimated Hours</FormLabel>
<FormControl>
<Input
type="number"
min="0"
step="0.5"
placeholder="0"
{...field}
onChange={(e) => field.onChange(parseFloat(e.target.value) || 0)}
/>
</FormControl>
<FormMessage />
</FormItem>
)}
/>
</div>
{/* Actions */}
<div className="flex justify-end gap-2">
<Button
type="button"
variant="outline"
onClick={() => onOpenChange(false)}
>
Cancel
</Button>
<Button type="submit" disabled={createMutation.isPending}>
{createMutation.isPending ? (
<>
<Loader2 className="mr-2 h-4 w-4 animate-spin" />
Creating...
</>
) : (
'Create Story'
)}
</Button>
</div>
</form>
</Form>
</DialogContent>
</Dialog>
);
}