Files
ColaFlow/colaflow-api/tests/Modules/Identity/ColaFlow.Modules.Identity.IntegrationTests/Identity/RoleManagementTests.cs
Yaojia Wang 6a70933886 test(signalr): Add comprehensive SignalR test suite
Implemented 90+ unit and integration tests for SignalR realtime collaboration:

Hub Unit Tests (59 tests - 100% passing):
- BaseHubTests.cs: 13 tests (connection, authentication, tenant isolation)
- ProjectHubTests.cs: 18 tests (join/leave project, typing indicators, permissions)
- NotificationHubTests.cs: 8 tests (mark as read, caller isolation)
- RealtimeNotificationServiceTests.cs: 17 tests (all notification methods)
- ProjectNotificationServiceAdapterTests.cs: 6 tests (adapter delegation)

Integration & Security Tests (31 tests):
- SignalRSecurityTests.cs: 10 tests (multi-tenant isolation, auth validation)
- SignalRCollaborationTests.cs: 10 tests (multi-user scenarios)
- TestJwtHelper.cs: JWT token generation utilities

Test Infrastructure:
- Created ColaFlow.API.Tests project with proper dependencies
- Added TestHelpers for reflection-based property extraction
- Updated ColaFlow.IntegrationTests with Moq and FluentAssertions

Test Metrics:
- Total Tests: 90 tests (59 unit + 31 integration)
- Pass Rate: 100% for unit tests (59/59)
- Pass Rate: 71% for integration tests (22/31 - 9 need refactoring)
- Code Coverage: Comprehensive coverage of all SignalR components
- Execution Time: <100ms for all unit tests

Coverage Areas:
 Hub connection lifecycle (connect, disconnect, abort)
 Authentication & authorization (JWT, claims extraction)
 Multi-tenant isolation (tenant groups, cross-tenant prevention)
 Real-time notifications (project, issue, user events)
 Permission validation (project membership checks)
 Typing indicators (multi-user collaboration)
 Service layer (RealtimeNotificationService, Adapter pattern)

Files Added:
- tests/ColaFlow.API.Tests/ (new test project)
  - ColaFlow.API.Tests.csproj
  - Helpers/TestHelpers.cs
  - Hubs/BaseHubTests.cs (13 tests)
  - Hubs/ProjectHubTests.cs (18 tests)
  - Hubs/NotificationHubTests.cs (8 tests)
  - Services/RealtimeNotificationServiceTests.cs (17 tests)
  - Services/ProjectNotificationServiceAdapterTests.cs (6 tests)
- tests/ColaFlow.IntegrationTests/SignalR/
  - SignalRSecurityTests.cs (10 tests)
  - SignalRCollaborationTests.cs (10 tests)
  - TestJwtHelper.cs

All unit tests passing. Integration tests demonstrate comprehensive scenarios
but need minor refactoring for mock verification precision.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-11-04 19:02:08 +01:00

569 lines
26 KiB
C#

using System.IdentityModel.Tokens.Jwt;
using System.Net;
using System.Net.Http.Headers;
using System.Net.Http.Json;
using ColaFlow.Modules.Identity.Application.Dtos;
using ColaFlow.Modules.Identity.IntegrationTests.Infrastructure;
using FluentAssertions;
namespace ColaFlow.Modules.Identity.IntegrationTests.Identity;
/// <summary>
/// Integration tests for Role Management API (Day 6)
/// Tests role assignment, user listing, user removal, and authorization policies
/// </summary>
public class RoleManagementTests(DatabaseFixture fixture) : IClassFixture<DatabaseFixture>
{
private readonly HttpClient _client = fixture.Client;
#region Category 1: List Users Tests (3 tests)
[Fact]
public async Task ListUsers_AsOwner_ShouldReturnPagedUsers()
{
// Arrange - Register tenant as Owner
var (ownerToken, tenantId, tenantSlug) = await RegisterTenantAndGetTokenAsync();
// Act - Owner lists users in their tenant
_client.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue("Bearer", ownerToken);
var response = await _client.GetAsync($"/api/tenants/{tenantId}/users?pageNumber=1&pageSize=20");
// Assert
response.StatusCode.Should().Be(HttpStatusCode.OK);
var result = await response.Content.ReadFromJsonAsync<PagedResultDto<UserWithRoleDto>>();
result.Should().NotBeNull();
result!.Items.Should().HaveCountGreaterThan(0, "At least the owner should be listed");
result.Items.Should().Contain(u => u.Role == "TenantOwner", "Owner should be in the list");
result.TotalCount.Should().BeGreaterThan(0);
result.PageNumber.Should().Be(1);
result.PageSize.Should().Be(20);
}
[Fact]
public async Task ListUsers_AsGuest_ShouldFail()
{
// NOTE: This test is limited by the lack of user invitation mechanism
// Without invitation, we can't properly create a guest user in a tenant
// For now, we test that unauthorized access is properly blocked
// Arrange - Create a tenant
var (ownerToken, tenantId, tenantSlug) = await RegisterTenantAndGetTokenAsync();
// Act - Try to list users without proper authorization (no token)
_client.DefaultRequestHeaders.Clear();
var response = await _client.GetAsync($"/api/tenants/{tenantId}/users");
// Assert - Should fail with 401 Unauthorized (no authentication)
response.StatusCode.Should().Be(HttpStatusCode.Unauthorized);
}
[Fact]
public async Task ListUsers_WithPagination_ShouldWork()
{
// Arrange - Register tenant
var (ownerToken, tenantId, tenantSlug) = await RegisterTenantAndGetTokenAsync();
// Act - Request with specific pagination
_client.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue("Bearer", ownerToken);
var response = await _client.GetAsync($"/api/tenants/{tenantId}/users?pageNumber=1&pageSize=5");
// Assert
response.StatusCode.Should().Be(HttpStatusCode.OK);
var result = await response.Content.ReadFromJsonAsync<PagedResultDto<UserWithRoleDto>>();
result.Should().NotBeNull();
result!.PageNumber.Should().Be(1);
result.PageSize.Should().Be(5);
result.TotalPages.Should().BeGreaterThan(0);
// Verify TotalPages calculation: TotalPages = Ceiling(TotalCount / PageSize)
var expectedTotalPages = (int)Math.Ceiling((double)result.TotalCount / result.PageSize);
result.TotalPages.Should().Be(expectedTotalPages);
}
#endregion
#region Category 2: Assign Role Tests (5 tests)
[Fact]
public async Task AssignRole_AsOwner_ShouldSucceed()
{
// NOTE: Limited test - tests updating owner's own role
// Full multi-user testing requires user invitation feature (Day 7+)
// Arrange - Register tenant (owner gets TenantOwner role by default)
var (ownerToken, tenantId, ownerId) = await RegisterTenantAndGetDetailedTokenAsync();
// Act - Owner changes their own role to TenantAdmin (this should work)
_client.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue("Bearer", ownerToken);
var response = await _client.PostAsJsonAsync(
$"/api/tenants/{tenantId}/users/{ownerId}/role",
new { Role = "TenantAdmin" });
// Assert
response.StatusCode.Should().Be(HttpStatusCode.OK);
var result = await response.Content.ReadFromJsonAsync<MessageResponse>();
result!.Message.Should().Contain("assigned successfully");
// Verify role was updated by listing users
var listResponse = await _client.GetAsync($"/api/tenants/{tenantId}/users");
var listResult = await listResponse.Content.ReadFromJsonAsync<PagedResultDto<UserWithRoleDto>>();
listResult!.Items.Should().Contain(u => u.UserId == ownerId && u.Role == "TenantAdmin");
}
[Fact]
public async Task AssignRole_RequiresOwnerPolicy_ShouldBeEnforced()
{
// NOTE: This test verifies the RequireTenantOwner policy is applied
// Full testing requires user invitation to create Admin users
// Arrange - Register tenant (owner)
var (ownerToken, tenantId, ownerId) = await RegisterTenantAndGetDetailedTokenAsync();
// Act - Owner can assign roles (should succeed)
_client.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue("Bearer", ownerToken);
var response = await _client.PostAsJsonAsync(
$"/api/tenants/{tenantId}/users/{ownerId}/role",
new { Role = "TenantMember" });
// Assert - Should succeed because owner has permission
response.StatusCode.Should().Be(HttpStatusCode.OK);
// TODO: Once user invitation is implemented:
// 1. Create an Admin user in the tenant
// 2. Get the Admin user's token
// 3. Verify Admin cannot assign roles (403 Forbidden)
}
[Fact]
public async Task AssignRole_AIAgent_ShouldFail()
{
// Arrange
var (ownerToken, tenantId, ownerId) = await RegisterTenantAndGetDetailedTokenAsync();
// Act - Owner tries to assign AIAgent role to themselves
_client.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue("Bearer", ownerToken);
var response = await _client.PostAsJsonAsync(
$"/api/tenants/{tenantId}/users/{ownerId}/role",
new { Role = "AIAgent" });
// Assert - Should fail with 400 Bad Request
response.StatusCode.Should().Be(HttpStatusCode.BadRequest);
var error = await response.Content.ReadAsStringAsync();
error.Should().Contain("AIAgent");
}
[Fact]
public async Task AssignRole_InvalidRole_ShouldFail()
{
// Arrange
var (ownerToken, tenantId, ownerId) = await RegisterTenantAndGetDetailedTokenAsync();
// Act - Try to assign invalid role
_client.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue("Bearer", ownerToken);
var response = await _client.PostAsJsonAsync(
$"/api/tenants/{tenantId}/users/{ownerId}/role",
new { Role = "InvalidRole" });
// Assert - Should fail with 400 Bad Request
response.StatusCode.Should().Be(HttpStatusCode.BadRequest);
}
[Fact]
public async Task AssignRole_UpdateExistingRole_ShouldSucceed()
{
// Arrange - Register tenant (owner starts with TenantOwner role)
var (ownerToken, tenantId, ownerId) = await RegisterTenantAndGetDetailedTokenAsync();
_client.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue("Bearer", ownerToken);
// Assign TenantMember role to owner
await _client.PostAsJsonAsync(
$"/api/tenants/{tenantId}/users/{ownerId}/role",
new { Role = "TenantMember" });
// Act - Update to TenantAdmin role
var response = await _client.PostAsJsonAsync(
$"/api/tenants/{tenantId}/users/{ownerId}/role",
new { Role = "TenantAdmin" });
// Assert
response.StatusCode.Should().Be(HttpStatusCode.OK);
// Verify role was updated
var listResponse = await _client.GetAsync($"/api/tenants/{tenantId}/users");
var listResult = await listResponse.Content.ReadFromJsonAsync<PagedResultDto<UserWithRoleDto>>();
listResult!.Items.Should().Contain(u => u.UserId == ownerId && u.Role == "TenantAdmin");
listResult.Items.Should().NotContain(u => u.UserId == ownerId && u.Role == "TenantMember");
}
#endregion
#region Category 3: Remove User Tests (4 tests)
[Fact]
public async Task RemoveUser_AsOwner_ShouldSucceed()
{
// Arrange - Register tenant (owner)
var (ownerToken, tenantId, ownerId) = await RegisterTenantAndGetDetailedTokenAsync();
var emailService = fixture.GetEmailService();
emailService.ClearSentEmails();
// Step 1: Owner invites another user to the tenant
_client.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue("Bearer", ownerToken);
var inviteResponse = await _client.PostAsJsonAsync(
$"/api/tenants/{tenantId}/invitations",
new { Email = "invited-user@test.com", Role = "TenantMember" });
inviteResponse.StatusCode.Should().Be(HttpStatusCode.OK);
// Step 2: Extract invitation token from email
emailService.SentEmails.Should().HaveCount(1);
var invitationEmail = emailService.SentEmails[0];
var invitationToken = TestAuthHelper.ExtractInvitationTokenFromEmail(invitationEmail.HtmlBody);
invitationToken.Should().NotBeNullOrEmpty();
// Step 3: New user accepts invitation
_client.DefaultRequestHeaders.Clear();
var acceptResponse = await _client.PostAsJsonAsync(
"/api/auth/invitations/accept",
new { Token = invitationToken, FullName = "Invited User", Password = "Invited@1234" });
acceptResponse.StatusCode.Should().Be(HttpStatusCode.OK);
var acceptResult = await acceptResponse.Content.ReadFromJsonAsync<AcceptInvitationResponse>();
var invitedUserId = acceptResult!.UserId;
// Step 4: Owner removes the invited user
_client.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue("Bearer", ownerToken);
var response = await _client.DeleteAsync($"/api/tenants/{tenantId}/users/{invitedUserId}");
// Assert
response.StatusCode.Should().Be(HttpStatusCode.OK);
// Verify user is no longer listed in the tenant
var listResponse = await _client.GetAsync($"/api/tenants/{tenantId}/users");
var listResult = await listResponse.Content.ReadFromJsonAsync<PagedResultDto<UserWithRoleDto>>();
listResult!.Items.Should().NotContain(u => u.UserId == invitedUserId);
}
[Fact]
public async Task RemoveUser_LastOwner_ShouldFail()
{
// Arrange - Register tenant (only one owner)
var (ownerToken, tenantId, ownerId) = await RegisterTenantAndGetDetailedTokenAsync();
// Act - Try to remove the only owner
_client.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue("Bearer", ownerToken);
var response = await _client.DeleteAsync($"/api/tenants/{tenantId}/users/{ownerId}");
// Assert - Should fail with 400 Bad Request
response.StatusCode.Should().Be(HttpStatusCode.BadRequest);
var error = await response.Content.ReadAsStringAsync();
error.Should().Contain("last");
}
[Fact]
public async Task RemoveUser_RevokesTokens_ShouldWork()
{
// Arrange - Register tenant A (owner A)
var (ownerAToken, tenantAId, tenantASlug) = await RegisterTenantAndGetTokenAsync();
var emailService = fixture.GetEmailService();
emailService.ClearSentEmails();
// Step 1: Invite user B to tenant A
_client.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue("Bearer", ownerAToken);
await _client.PostAsJsonAsync(
$"/api/tenants/{tenantAId}/invitations",
new { Email = "userb@test.com", Role = "TenantMember" });
// Step 2: User B accepts invitation
var invitationToken = TestAuthHelper.ExtractInvitationTokenFromEmail(emailService.SentEmails[0].HtmlBody);
_client.DefaultRequestHeaders.Clear();
var acceptResponse = await _client.PostAsJsonAsync(
"/api/auth/invitations/accept",
new { Token = invitationToken, FullName = "User B", Password = "UserB@1234" });
var acceptResult = await acceptResponse.Content.ReadFromJsonAsync<AcceptInvitationResponse>();
var userBId = acceptResult!.UserId;
// Step 3: User B logs into tenant A and gets tokens
var (userBToken, userBRefreshToken) = await TestAuthHelper.LoginAndGetTokensAsync(
_client, tenantASlug, "userb@test.com", "UserB@1234");
// Step 4: Owner A removes user B from tenant A
_client.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue("Bearer", ownerAToken);
var removeResponse = await _client.DeleteAsync($"/api/tenants/{tenantAId}/users/{userBId}");
removeResponse.StatusCode.Should().Be(HttpStatusCode.OK);
// Step 5: Verify user B's refresh tokens for tenant A are revoked
_client.DefaultRequestHeaders.Clear();
var refreshResponse = await _client.PostAsJsonAsync(
"/api/auth/refresh",
new { RefreshToken = userBRefreshToken });
refreshResponse.StatusCode.Should().Be(HttpStatusCode.Unauthorized,
"User B's refresh tokens should be revoked after removal");
}
[Fact]
public async Task RemoveUser_RequiresOwnerPolicy_ShouldBeEnforced()
{
// Arrange - Register tenant (owner)
var (ownerToken, tenantId, tenantSlug) = await RegisterTenantAndGetTokenAsync();
var emailService = fixture.GetEmailService();
// Step 1: Invite user A as TenantAdmin
emailService.ClearSentEmails();
_client.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue("Bearer", ownerToken);
await _client.PostAsJsonAsync(
$"/api/tenants/{tenantId}/invitations",
new { Email = "admin@test.com", Role = "TenantAdmin" });
var adminInvitationToken = TestAuthHelper.ExtractInvitationTokenFromEmail(emailService.SentEmails[0].HtmlBody);
_client.DefaultRequestHeaders.Clear();
await _client.PostAsJsonAsync(
"/api/auth/invitations/accept",
new { Token = adminInvitationToken, FullName = "Admin User", Password = "Admin@1234" });
var (adminToken, _) = await TestAuthHelper.LoginAndGetTokensAsync(
_client, tenantSlug, "admin@test.com", "Admin@1234");
// Step 2: Invite user B as TenantMember
emailService.ClearSentEmails();
_client.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue("Bearer", ownerToken);
await _client.PostAsJsonAsync(
$"/api/tenants/{tenantId}/invitations",
new { Email = "member@test.com", Role = "TenantMember" });
var memberInvitationToken = TestAuthHelper.ExtractInvitationTokenFromEmail(emailService.SentEmails[0].HtmlBody);
_client.DefaultRequestHeaders.Clear();
var memberAcceptResponse = await _client.PostAsJsonAsync(
"/api/auth/invitations/accept",
new { Token = memberInvitationToken, FullName = "Member User", Password = "Member@1234" });
var memberAcceptResult = await memberAcceptResponse.Content.ReadFromJsonAsync<AcceptInvitationResponse>();
var memberUserId = memberAcceptResult!.UserId;
// Step 3: Admin A tries to remove user B (should fail with 403 Forbidden)
_client.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue("Bearer", adminToken);
var adminRemoveResponse = await _client.DeleteAsync($"/api/tenants/{tenantId}/users/{memberUserId}");
adminRemoveResponse.StatusCode.Should().Be(HttpStatusCode.Forbidden,
"TenantAdmin should NOT be able to remove users (only TenantOwner can)");
// Step 4: Owner removes user B (should succeed)
_client.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue("Bearer", ownerToken);
var ownerRemoveResponse = await _client.DeleteAsync($"/api/tenants/{tenantId}/users/{memberUserId}");
ownerRemoveResponse.StatusCode.Should().Be(HttpStatusCode.OK,
"TenantOwner should be able to remove users");
}
#endregion
#region Category 4: Get Roles Tests (1 test)
[Fact(Skip = "Endpoint route needs to be fixed - '../roles' notation doesn't work in ASP.NET Core")]
public async Task GetRoles_AsAdmin_ShouldReturnAllRoles()
{
// NOTE: The GetAvailableRoles endpoint uses [HttpGet("../roles")] which doesn't work properly
// The route should be updated to use a separate controller or absolute route
// TODO: Fix the endpoint route in TenantUsersController
// Option 1: Create separate RolesController with route [Route("api/tenants/roles")]
// Option 2: Use absolute route [HttpGet("~/api/tenants/roles")]
// Option 3: Move to tenant controller with route [Route("api/tenants")], [HttpGet("roles")]
// Arrange - Register tenant as Owner
var (ownerToken, tenantId, tenantSlug) = await RegisterTenantAndGetTokenAsync();
// Act - Try the current route (will likely fail with 404)
_client.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue("Bearer", ownerToken);
var response = await _client.GetAsync($"/api/tenants/{tenantId}/roles");
// Assert - Once route is fixed, this test should pass
if (response.StatusCode == HttpStatusCode.OK)
{
var roles = await response.Content.ReadFromJsonAsync<List<RoleDto>>();
roles.Should().NotBeNull();
roles!.Should().HaveCount(4, "Should return 4 assignable roles (excluding AIAgent)");
roles.Should().Contain(r => r.Name == "TenantOwner");
roles.Should().Contain(r => r.Name == "TenantAdmin");
roles.Should().Contain(r => r.Name == "TenantMember");
roles.Should().Contain(r => r.Name == "TenantGuest");
roles.Should().NotContain(r => r.Name == "AIAgent", "AIAgent should not be in assignable roles");
}
await Task.CompletedTask;
}
#endregion
#region Category 5: Cross-Tenant Protection Tests (5 tests)
[Fact]
public async Task ListUsers_WithCrossTenantAccess_ShouldReturn403Forbidden()
{
// Arrange - Create two separate tenants
var (ownerAToken, tenantAId, tenantASlug) = await RegisterTenantAndGetTokenAsync();
var (ownerBToken, tenantBId, tenantBSlug) = await RegisterTenantAndGetTokenAsync();
// Act - Tenant A owner tries to list Tenant B users
_client.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue("Bearer", ownerAToken);
var response = await _client.GetAsync($"/api/tenants/{tenantBId}/users");
// Assert - Should return 403 Forbidden
response.StatusCode.Should().Be(HttpStatusCode.Forbidden,
"Users should not be able to access other tenants' user lists");
var errorContent = await response.Content.ReadAsStringAsync();
errorContent.Should().Contain("your own tenant",
"Error message should explain tenant isolation");
}
[Fact]
public async Task AssignRole_WithCrossTenantAccess_ShouldReturn403Forbidden()
{
// Arrange - Create two separate tenants
var (ownerAToken, tenantAId, tenantASlug) = await RegisterTenantAndGetTokenAsync();
var (ownerBToken, tenantBId, userBId) = await RegisterTenantAndGetDetailedTokenAsync();
// Act - Tenant A owner tries to assign role in Tenant B
_client.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue("Bearer", ownerAToken);
var response = await _client.PostAsJsonAsync(
$"/api/tenants/{tenantBId}/users/{userBId}/role",
new { Role = "TenantMember" });
// Assert - Should return 403 Forbidden
response.StatusCode.Should().Be(HttpStatusCode.Forbidden,
"Users should not be able to assign roles in other tenants");
var errorContent = await response.Content.ReadAsStringAsync();
errorContent.Should().Contain("your own tenant",
"Error message should explain tenant isolation");
}
[Fact]
public async Task RemoveUser_WithCrossTenantAccess_ShouldReturn403Forbidden()
{
// Arrange - Create two separate tenants
var (ownerAToken, tenantAId, tenantASlug) = await RegisterTenantAndGetTokenAsync();
var (ownerBToken, tenantBId, userBId) = await RegisterTenantAndGetDetailedTokenAsync();
// Act - Tenant A owner tries to remove user from Tenant B
_client.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue("Bearer", ownerAToken);
var response = await _client.DeleteAsync($"/api/tenants/{tenantBId}/users/{userBId}");
// Assert - Should return 403 Forbidden
response.StatusCode.Should().Be(HttpStatusCode.Forbidden,
"Users should not be able to remove users from other tenants");
var errorContent = await response.Content.ReadAsStringAsync();
errorContent.Should().Contain("your own tenant",
"Error message should explain tenant isolation");
}
[Fact]
public async Task ListUsers_WithSameTenantAccess_ShouldReturn200OK()
{
// Arrange - Register tenant
var (ownerToken, tenantId, tenantSlug) = await RegisterTenantAndGetTokenAsync();
// Act - Tenant owner accesses their own tenant's users
_client.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue("Bearer", ownerToken);
var response = await _client.GetAsync($"/api/tenants/{tenantId}/users");
// Assert - Should return 200 OK (regression test - ensure same-tenant access still works)
response.StatusCode.Should().Be(HttpStatusCode.OK,
"Users should be able to access their own tenant's resources");
var result = await response.Content.ReadFromJsonAsync<PagedResultDto<UserWithRoleDto>>();
result.Should().NotBeNull();
result!.Items.Should().HaveCountGreaterThan(0, "Owner should be listed in their own tenant");
}
[Fact]
public async Task CrossTenantProtection_WithMultipleEndpoints_ShouldBeConsistent()
{
// Arrange - Create two separate tenants
var (ownerAToken, tenantAId, userAId) = await RegisterTenantAndGetDetailedTokenAsync();
var (ownerBToken, tenantBId, userBId) = await RegisterTenantAndGetDetailedTokenAsync();
_client.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue("Bearer", ownerAToken);
// Act & Assert - Test all three endpoints consistently block cross-tenant access
var listUsersResponse = await _client.GetAsync($"/api/tenants/{tenantBId}/users");
listUsersResponse.StatusCode.Should().Be(HttpStatusCode.Forbidden,
"ListUsers should block cross-tenant access");
var assignRoleResponse = await _client.PostAsJsonAsync(
$"/api/tenants/{tenantBId}/users/{userBId}/role",
new { Role = "TenantMember" });
assignRoleResponse.StatusCode.Should().Be(HttpStatusCode.Forbidden,
"AssignRole should block cross-tenant access");
var removeUserResponse = await _client.DeleteAsync($"/api/tenants/{tenantBId}/users/{userBId}");
removeUserResponse.StatusCode.Should().Be(HttpStatusCode.Forbidden,
"RemoveUser should block cross-tenant access");
// Verify same-tenant access still works for Tenant A
_client.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue("Bearer", ownerAToken);
var sameTenantResponse = await _client.GetAsync($"/api/tenants/{tenantAId}/users");
sameTenantResponse.StatusCode.Should().Be(HttpStatusCode.OK,
"Same-tenant access should still work");
}
#endregion
#region Helper Methods
/// <summary>
/// Register a tenant and return access token and tenant ID
/// </summary>
private async Task<(string accessToken, Guid tenantId, string tenantSlug)> RegisterTenantAndGetTokenAsync()
{
var (accessToken, _) = await TestAuthHelper.RegisterAndGetTokensAsync(_client);
var handler = new JwtSecurityTokenHandler();
var token = handler.ReadJwtToken(accessToken);
var tenantId = Guid.Parse(token.Claims.First(c => c.Type == "tenant_id").Value);
var tenantSlug = token.Claims.First(c => c.Type == "tenant_slug").Value;
return (accessToken, tenantId, tenantSlug);
}
/// <summary>
/// Register a tenant and return access token, tenant ID, and user ID
/// </summary>
private async Task<(string accessToken, Guid tenantId, Guid userId)> RegisterTenantAndGetDetailedTokenAsync()
{
var (accessToken, refreshToken) = await TestAuthHelper.RegisterAndGetTokensAsync(_client);
var handler = new JwtSecurityTokenHandler();
var token = handler.ReadJwtToken(accessToken);
var tenantId = Guid.Parse(token.Claims.First(c => c.Type == "tenant_id").Value);
var userId = Guid.Parse(token.Claims.First(c => c.Type == "user_id").Value);
return (accessToken, tenantId, userId);
}
/// <summary>
/// Register a tenant and return access token, refresh token, and user ID (for token revocation tests)
/// </summary>
private async Task<(string accessToken, string refreshToken, Guid userId)> RegisterTenantAndGetAllTokensAsync()
{
var (accessToken, refreshToken) = await TestAuthHelper.RegisterAndGetTokensAsync(_client);
var handler = new JwtSecurityTokenHandler();
var token = handler.ReadJwtToken(accessToken);
var userId = Guid.Parse(token.Claims.First(c => c.Type == "user_id").Value);
return (accessToken, refreshToken, userId);
}
#endregion
}
// Response DTOs for deserialization
public record MessageResponse(string Message);
public record RoleDto(string Name, string Description);