feat(ios): comprehensive iPhone+iPad UX polish — refined-native design system
Freeze a shared design system (DesignSystem/{Tokens,Typography,StatusStyle,
Primitives}.swift): indigo #7C8CFF accent (root .tint), semantic status colors,
2-4-8-12-16-20-24 spacing + sm8/md12/lg16 radii scale, SF Mono tabular numbers,
reduce-motion-gated animations, haptics, reusable StatusBadge/TelemetryChip/Card/
SectionHeader/DSButtonStyle/ContinueLastBanner. Every changed view consumes tokens
— no hardcoded colors/spacing.
Applied across all surfaces (visual only — zero behavior/logic change, all suites
green): session list rows + status system (shape+color, not color-alone) +
telemetry chips + thumbnail placeholders; terminal gate card (≥44pt approve/reject)
+ keybar + reconnect + quick-reply + digest + SwiftTerm accent theme; pairing hero
+ warning tiers + Projects cards + Timeline/Diff; nav chrome + iPad split placeholder
+ privacy shade + motion. Chinese gate copy. UX finding fixed: timeline class colors
now via DS.Palette (+timelineTool/timelineUser tokens).
Design review 8.5/10. Verified: iPhone 16 290 + iPad Pro 11 290 tests green;
packages + integration green; consistency audit ~clean; zero changes under
ios/Packages, src/, public/.
This commit is contained in:
@@ -16,40 +16,69 @@ struct PlanGateSheet: View {
|
||||
let gate: GateState
|
||||
let onDecide: (GateState.Affordance, Int) -> Void
|
||||
|
||||
private enum Metrics {
|
||||
static let spacing: CGFloat = 12
|
||||
static let padding: CGFloat = 20
|
||||
static let captionSpacing: CGFloat = 2
|
||||
private enum Copy {
|
||||
/// Chinese lead-in above the (web-mirrored) English question.
|
||||
static let heading = "计划已就绪"
|
||||
}
|
||||
|
||||
var body: some View {
|
||||
VStack(alignment: .leading, spacing: Metrics.spacing) {
|
||||
Text(Self.title)
|
||||
.font(.headline)
|
||||
ForEach(GateChoiceSpec.specs(for: gate), id: \.affordance) { spec in
|
||||
choiceButton(spec)
|
||||
VStack(alignment: .leading, spacing: DS.Space.lg16) {
|
||||
VStack(alignment: .leading, spacing: DS.Space.xs4) {
|
||||
Text(Copy.heading)
|
||||
.font(DS.Typography.caption)
|
||||
.foregroundStyle(DS.Palette.textSecondary)
|
||||
Text(Self.title)
|
||||
.font(DS.Typography.headline)
|
||||
.foregroundStyle(DS.Palette.textPrimary)
|
||||
.fixedSize(horizontal: false, vertical: true)
|
||||
}
|
||||
ScrollView {
|
||||
VStack(spacing: DS.Space.sm8) {
|
||||
ForEach(GateChoiceSpec.specs(for: gate), id: \.affordance) { spec in
|
||||
choiceButton(spec)
|
||||
}
|
||||
}
|
||||
}
|
||||
.scrollBounceBehavior(.basedOnSize)
|
||||
}
|
||||
.padding(Metrics.padding)
|
||||
.padding(DS.Space.xl20)
|
||||
.frame(maxWidth: .infinity, alignment: .leading)
|
||||
.presentationDetents([.medium])
|
||||
.accessibilityElement(children: .contain)
|
||||
}
|
||||
|
||||
/// One full-width choice Card: semantic icon + label + the plain-language
|
||||
/// caption of what the wire mode actually does + a disclosure chevron. The
|
||||
/// whole card is the (large) tap target.
|
||||
private func choiceButton(_ spec: GateChoiceSpec) -> some View {
|
||||
Button {
|
||||
onDecide(spec.affordance, gate.epoch) // epoch of the RENDERED gate
|
||||
} label: {
|
||||
VStack(alignment: .leading, spacing: Metrics.captionSpacing) {
|
||||
Text(spec.label)
|
||||
.font(.body.weight(.medium))
|
||||
Text(Self.caption(for: spec.affordance))
|
||||
.font(.caption)
|
||||
.foregroundStyle(.secondary)
|
||||
Card(padding: DS.Space.md12) {
|
||||
HStack(spacing: DS.Space.md12) {
|
||||
Image(systemName: symbol(for: spec.affordance))
|
||||
.font(DS.Typography.title)
|
||||
.foregroundStyle(iconColor(for: spec.affordance))
|
||||
.frame(width: DS.Space.xxl24)
|
||||
VStack(alignment: .leading, spacing: DS.Space.xs2) {
|
||||
Text(spec.label)
|
||||
.font(DS.Typography.body.weight(.semibold))
|
||||
.foregroundStyle(DS.Palette.textPrimary)
|
||||
Text(Self.caption(for: spec.affordance))
|
||||
.font(DS.Typography.caption)
|
||||
.foregroundStyle(DS.Palette.textSecondary)
|
||||
.fixedSize(horizontal: false, vertical: true)
|
||||
}
|
||||
Spacer(minLength: DS.Space.sm8)
|
||||
Image(systemName: "chevron.right")
|
||||
.font(DS.Typography.caption)
|
||||
.foregroundStyle(DS.Palette.textTertiary)
|
||||
}
|
||||
.frame(maxWidth: .infinity, alignment: .leading)
|
||||
}
|
||||
.frame(maxWidth: .infinity, alignment: .leading)
|
||||
}
|
||||
.buttonStyle(.bordered)
|
||||
.tint(tint(for: spec.affordance))
|
||||
.buttonStyle(.plain)
|
||||
.accessibilityIdentifier("plan.decision.\(spec.affordance)")
|
||||
}
|
||||
|
||||
/// Secondary line under each choice: what the wire mode actually does.
|
||||
@@ -63,11 +92,27 @@ struct PlanGateSheet: View {
|
||||
}
|
||||
}
|
||||
|
||||
private func tint(for affordance: GateState.Affordance) -> Color {
|
||||
/// Distinct SF Symbol per choice (shape carries meaning, not just color):
|
||||
/// Auto = a bolt (fast, hands-off), Review = a checkmark (approve, confirm
|
||||
/// each edit), Keep Planning = a pencil (stay drafting).
|
||||
private func symbol(for affordance: GateState.Affordance) -> String {
|
||||
switch affordance {
|
||||
case .approve, .approveAuto, .approveReview: return .green
|
||||
case .reject: return .red
|
||||
case .keepPlanning: return .indigo
|
||||
case .approveAuto: return "bolt.fill"
|
||||
case .approveReview: return "checkmark.circle"
|
||||
case .keepPlanning: return "pencil.and.outline"
|
||||
case .approve: return "checkmark.circle"
|
||||
case .reject: return "xmark.circle"
|
||||
}
|
||||
}
|
||||
|
||||
/// Both approve paths wear the accent (this is the encouraged action); Keep
|
||||
/// Planning is a quiet secondary; a bare reject (tool-shaped, unused here)
|
||||
/// stays the stuck red.
|
||||
private func iconColor(for affordance: GateState.Affordance) -> Color {
|
||||
switch affordance {
|
||||
case .approveAuto, .approveReview, .approve: return DS.Palette.accent
|
||||
case .keepPlanning: return DS.Palette.textSecondary
|
||||
case .reject: return DS.Palette.statusStuck
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user