Add a `desktop/` Electron app that embeds the existing Node server + node-pty (all-in-one): the window loads http://127.0.0.1:<port>/ and reuses the frontend unchanged; other LAN devices can still connect. The server needs zero changes — startServer(cfg)/loadConfig already support programmatic embedding. - Pure, unit-tested modules: port, shell, server-config, deep-link, notify-policy, notifications, live-poll, prefs, settings-store (94 tests; desktop/src ~97% cov) - Electron glue: main/window/tray/menu/preload/embedded-server/logger (hardened: contextIsolation, sandbox, deny foreign-origin navigation) - Native value: OS notifications driven by /live-sessions status, tray, deep links - Packaging (electron-builder -> arm64 .dmg): ships dist/ + public/ + node_modules on-disk under Resources so the server resolves its deps from /Applications; node-pty rebuilt for the Electron ABI - Docs: docs/DESKTOP_PLAN.md; PROGRESS_LOG updated Verified: desktop tsc clean; 1401 tests pass; coverage >=80% (desktop/src 97/95/100/97); .dmg built and launch-tested on arm64 (server boots, UI serves 200, node-pty loads).
73 lines
2.9 KiB
TypeScript
73 lines
2.9 KiB
TypeScript
/**
|
|
* desktop/src/embedded-server.ts — GLUE: start the reused backend server inside
|
|
* the Electron main process.
|
|
*
|
|
* All pure logic lives in the sibling modules (port / server-config / shell);
|
|
* this file only wires them to electron + the compiled backend under dist/. It
|
|
* resolves a DEFINITE free port BEFORE loadConfig (the backend derives
|
|
* allowedOrigins from the port — config.ts M1), then dynamically imports the
|
|
* compiled ESM server (dist/server.js) and config (dist/config.js) by absolute
|
|
* file URL. The specifiers are computed so esbuild leaves them external (never
|
|
* bundling native node-pty). The Config type import from ../../src/types.js is
|
|
* type-only and erased at build time — no runtime dependency on src/.
|
|
*/
|
|
|
|
import path from 'node:path'
|
|
import { pathToFileURL } from 'node:url'
|
|
import { app } from 'electron'
|
|
import type { Config } from '../../src/types.js'
|
|
import type { DesktopPrefs, EmbeddedServer } from './types.js'
|
|
import type { Logger } from './logger.js'
|
|
import { pickFreePort } from './port.js'
|
|
import { buildServerEnv } from './server-config.js'
|
|
|
|
/** Default listen port when the user hasn't pinned one (free-port fallback still applies). */
|
|
const DEFAULT_PORT = 3000
|
|
|
|
export interface EmbeddedServerDeps {
|
|
readonly prefs: DesktopPrefs
|
|
readonly logger: Logger
|
|
}
|
|
|
|
/** The runtime handle the compiled backend's startServer() returns. */
|
|
interface ServerHandle {
|
|
close(): Promise<void>
|
|
}
|
|
|
|
/**
|
|
* Start the embedded backend and return a lifecycle handle. Throws (after
|
|
* logging) if the compiled server can't be imported or fails to start — the app
|
|
* is useless without it, so callers must surface the failure, not swallow it.
|
|
*/
|
|
export async function startEmbeddedServer(deps: EmbeddedServerDeps): Promise<EmbeddedServer> {
|
|
const { prefs, logger } = deps
|
|
const port = await pickFreePort(prefs.port ?? DEFAULT_PORT)
|
|
const env = buildServerEnv({ prefs, port, platform: process.platform, env: process.env })
|
|
|
|
// dist/ is a sibling of the desktop dir in dev; under resourcesPath when packaged.
|
|
const base = app.isPackaged ? process.resourcesPath : path.join(app.getAppPath(), '..')
|
|
const configUrl = pathToFileURL(path.join(base, 'dist', 'config.js')).href
|
|
const serverUrl = pathToFileURL(path.join(base, 'dist', 'server.js')).href
|
|
|
|
try {
|
|
const { loadConfig } = (await import(configUrl)) as {
|
|
loadConfig: (e: Record<string, string | undefined>) => Config
|
|
}
|
|
const { startServer } = (await import(serverUrl)) as {
|
|
startServer: (c: Config) => ServerHandle
|
|
}
|
|
const cfg = loadConfig(env)
|
|
const handle = startServer(cfg)
|
|
logger.info(`embedded server listening on http://${cfg.bindHost}:${cfg.port}`)
|
|
return {
|
|
port,
|
|
bindHost: cfg.bindHost,
|
|
allowedOrigins: cfg.allowedOrigins,
|
|
close: () => handle.close(),
|
|
}
|
|
} catch (err: unknown) {
|
|
logger.error('failed to start embedded server', err)
|
|
throw err
|
|
}
|
|
}
|