cc811dd18d
`npm test` was failing 5-11 tests per run with the set shifting between runs, which made it useless as a gate. Two independent causes, neither of them a product defect. 1. Fixtures had outgrown vitest's 5 s default. The git ones spawn 6-12 sequential `git` processes (init/config/commit/clone/push); the real-server ones boot a server and a shell. Alone they finish easily; under a full parallel run they do not, and the failure reads `Test timed out in 5000ms`. Gave those describes an explicit 30 s ceiling, and the real-PTY waits a named PTY_WAIT_MS. The deliberate short bounds in the "must be rejected" handshake tests are left alone — there a timeout IS the assertion. (The same rebudgeting also touched the test files in the preceding commit.) 2. test/integration/server.test.ts cannot share the machine with the rest of the suite. It asserts on real prompt output within seconds, which is not achievable while ~8 workers saturate the box: it passed alone (27/27, repeatedly) and flaked in the full run. Raising the numbers further only moved the flake around, so this is fixed as a scheduling problem — `npm test` now runs two passes, `test:unit` (everything else, parallel) then `test:e2e` (that file on its own). `vitest run` still runs everything at once for anyone who wants that. Also bounded the srv.close() in H1's finally. Unbounded, it swallowed whatever really went wrong in the body — the inner waits threw, control jumped to the finally, close() blocked, and the case reported a bare timeout instead of its own diagnosis. The root-causing above only became possible after making that failure legible. Note on the `[needs real PTY (sandbox-off)]` labels: those cases were NOT skipping here. PTY_AVAILABLE is true on this machine, so they were running and failing on timing, not being gated out by a sandbox. Verified: npm test green end to end across repeated runs (unit 78 files / 2147 tests, e2e 27).
70 lines
3.0 KiB
TypeScript
70 lines
3.0 KiB
TypeScript
import { defineConfig } from 'vitest/config'
|
|
|
|
export default defineConfig({
|
|
test: {
|
|
include: ['test/**/*.test.ts'],
|
|
// `npm test` runs two passes (see package.json): the unit/integration bulk in
|
|
// parallel, then test/integration/server.test.ts on its own. That file boots a
|
|
// real server and a real shell and asserts on prompt output within seconds —
|
|
// budgets it cannot meet while ~8 workers saturate the machine. It passed
|
|
// alone and flaked in the full run, which is a scheduling problem, not a
|
|
// timeout value to keep raising. `vitest run` still runs everything at once.
|
|
exclude: ['node_modules/**', 'dist/**'],
|
|
environment: 'node',
|
|
// jsdom 29's localStorage methods are undefined under this config; a shared
|
|
// in-memory Web Storage polyfill fixes the frontend (@vitest-environment
|
|
// jsdom) tests that call localStorage.clear()/setItem(). No-op in node env.
|
|
setupFiles: ['test/setup/local-storage.ts'],
|
|
// Scaffold has no tests yet; don't fail the script until modules add theirs.
|
|
passWithNoTests: true,
|
|
// Coverage target is the global 80% rule; enforced with `--coverage`.
|
|
// Scope: all backend src/** (the review's core), plus the frontend modules
|
|
// that carry real logic and have unit tests. The remaining public/*.ts are
|
|
// thin DOM-wiring / entry-point glue (main.ts boots the app; dashboard/qr/
|
|
// share/shortcuts/search/keybar/settings/history just build + wire DOM) with
|
|
// no branch logic worth unit-testing in this fix-pass — excluded so the
|
|
// threshold measures tested surface, not untestable wiring. (Browser-driven
|
|
// E2E, not unit tests, is the right tool for those.)
|
|
coverage: {
|
|
provider: 'v8',
|
|
include: [
|
|
'src/**/*.ts',
|
|
'public/terminal-session.ts',
|
|
'public/link-paths.ts',
|
|
'public/queue.ts',
|
|
'public/tabs.ts',
|
|
'public/fanout.ts',
|
|
'public/grid-layout.ts',
|
|
'public/grid-presets.ts',
|
|
'public/cell-monitor.ts',
|
|
'public/preview-grid.ts',
|
|
'public/git-log.ts',
|
|
'public/digest.ts',
|
|
'public/title-util.ts',
|
|
'public/voice-commands.ts',
|
|
'public/voice-confirm.ts',
|
|
// Desktop (Electron) shell: only the PURE logic modules are measured.
|
|
// The Electron glue (main/window/tray/menu/notifications/preload/
|
|
// embedded-server/settings-store) is thin, side-effectful wiring around
|
|
// the electron/native/dist APIs — untestable as a unit and excluded on
|
|
// the same principle as the thin DOM-wiring public/*.ts above.
|
|
'desktop/src/port.ts',
|
|
'desktop/src/shell.ts',
|
|
'desktop/src/server-config.ts',
|
|
'desktop/src/deep-link.ts',
|
|
'desktop/src/notify-policy.ts',
|
|
'desktop/src/notifications.ts',
|
|
'desktop/src/live-poll.ts',
|
|
'desktop/src/prefs.ts',
|
|
'desktop/src/settings-store.ts',
|
|
],
|
|
thresholds: {
|
|
lines: 80,
|
|
functions: 80,
|
|
branches: 80,
|
|
statements: 80,
|
|
},
|
|
},
|
|
},
|
|
})
|