Files
writer-work-flow/apps/api/tests/test_job_runner.py
Yaojia Wang 345cc73965 fix(txn+security): 仓储改 flush + 启动校验/兜底 + job.error 脱敏 + SSE 异常硬化
P0-1 SqlCredentialStore/save_draft 由自提交改 flush,端点/服务统一 commit
  (新增 CredentialStore.commit() 统一提交点;token 刷新落库显式提交);
  补多凭据一请求中途失败整体回滚集成测试。
P0-2 启动校验 _fernet(enc_key) 快速失败 + catch-all Exception → ErrorEnvelope;
  credential_enc_key 改 SecretStr。
P0-3 run_job 异常分类:AppError 存 code+message,其余存通用文案不泄 str(exc)。
P0-4 评审/正文 SSE 失败先发 error 事件,尾部 commit 包 try/except。
P1-4 max_version 加 FOR UPDATE 行锁消除 TOCTOU。
P1-5 scan_overdue 谓词下推 + 批量 UPDATE RETURNING。
P1-10 移除 OAuth user_code 日志。
P2 provider_deps 改调网关 build_adapter;accept_service Committable Protocol;
  CORS 白名单收窄;request_id 安全字符集白名单;stdlib 日志接管;读端点 404 校验;
  httpx timeout;测试用合法 Fernet key;类型化响应模型(JobResponse/DimensionEntry/
  ReviewConflictView/selling_points)+路由 ErrorEnvelope responses(供 codegen)。
2026-06-21 19:32:24 +02:00

172 lines
5.2 KiB
Python
Raw Permalink Blame History

This file contains ambiguous Unicode characters

This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

"""T4.1 通用长任务 runner 单测ARCH §7.4)。
直接 `await run_job(...)`(不起后台线程、不连真 DB注入 fake session 工厂 + fake job
repo + fake work断言
- 成功路set_running → work → complete(result) → commit
- 失败路work 抛 → 回滚 → 新 session 里 fail(error) → commit且异常不冒泡。
独立 session 纪律 = `run_job` 自建 session经 session_factory与 `run_overdue_scan`
先例一致。这里的 fake session 工厂记录开了几次 session + 各次 commit。
"""
from __future__ import annotations
import uuid
from collections.abc import AsyncIterator
from contextlib import asynccontextmanager
from dataclasses import dataclass, field
from typing import Any
from sqlalchemy.ext.asyncio import AsyncSession
from ww_api.services.job_runner import run_job
from ww_core.domain.job_repo import (
PROGRESS_COMPLETE,
STATUS_DONE,
STATUS_FAILED,
STATUS_RUNNING,
JobView,
)
JOB_ID = uuid.UUID("00000000-0000-0000-0000-0000000000aa")
class _FakeSession:
"""最小 fake记录 commit 次数(提交边界断言)。"""
def __init__(self) -> None:
self.commits = 0
async def commit(self) -> None:
self.commits += 1
class _FakeSessionFactory:
"""独立 session 工厂替身:`()` → async-CM 产新 `_FakeSession`,记录开了几次。"""
def __init__(self) -> None:
self.sessions: list[_FakeSession] = []
def __call__(self) -> Any:
session = _FakeSession()
self.sessions.append(session)
@asynccontextmanager
async def _cm() -> AsyncIterator[_FakeSession]:
yield session
return _cm()
@dataclass
class _FakeJobRepo:
"""内存 job repo记录状态流转 + result/error不触 DB"""
status: str = "queued"
progress: int = 0
result: dict[str, Any] | None = None
error: str | None = None
calls: list[str] = field(default_factory=list)
def _view(self, job_id: uuid.UUID) -> JobView:
return JobView(
id=job_id,
kind="style_learn",
status=self.status,
progress=self.progress,
result=self.result,
error=self.error,
)
async def set_running(self, job_id: uuid.UUID) -> JobView:
self.calls.append("set_running")
self.status = STATUS_RUNNING
return self._view(job_id)
async def complete(self, job_id: uuid.UUID, result: dict[str, Any]) -> JobView:
self.calls.append("complete")
self.status = STATUS_DONE
self.progress = PROGRESS_COMPLETE
self.result = dict(result)
return self._view(job_id)
async def fail(self, job_id: uuid.UUID, error: str) -> JobView:
self.calls.append("fail")
self.status = STATUS_FAILED
self.error = error
return self._view(job_id)
# ---- success path ----
async def test_run_job_success_sets_done_and_commits() -> None:
factory = _FakeSessionFactory()
repo = _FakeJobRepo()
received: list[AsyncSession] = []
async def work(session: AsyncSession) -> dict[str, Any]:
received.append(session)
return {"version": 1, "dims_count": 16}
await run_job(
factory,
JOB_ID,
work,
repo_factory=lambda _s: repo,
)
assert repo.calls == ["set_running", "complete"]
assert repo.status == STATUS_DONE
assert repo.progress == PROGRESS_COMPLETE
assert repo.result == {"version": 1, "dims_count": 16}
# 自建了一个独立 session 且提交了一次
assert len(factory.sessions) == 1
assert factory.sessions[0].commits == 1
# work 拿到的就是 run_job 自建的 session
assert len(received) == 1
# ---- failure path ----
async def test_run_job_failure_sets_failed_and_does_not_raise() -> None:
factory = _FakeSessionFactory()
repo = _FakeJobRepo()
async def work(_session: AsyncSession) -> dict[str, Any]:
raise RuntimeError("extraction blew up: secret=/internal/path")
# 异常被吞(后台任务边界),不冒泡
await run_job(
factory,
JOB_ID,
work,
repo_factory=lambda _s: repo,
)
assert "complete" not in repo.calls
assert "fail" in repo.calls
assert repo.status == STATUS_FAILED
# P0-3非 AppError 一律落通用文案,**绝不**回传 str(exc)(防泄露内部细节)。
assert repo.error == "任务执行失败"
assert "secret" not in (repo.error or "")
# 失败置态在一个**全新** session 里完成并 commit原事务作废
assert len(factory.sessions) == 2
assert factory.sessions[1].commits == 1
async def test_run_job_apperror_stores_code_and_safe_message() -> None:
"""P0-3AppError 的 message 是面向用户的安全文案,连同 code 一起落库。"""
from ww_shared import AppError, ErrorCode
factory = _FakeSessionFactory()
repo = _FakeJobRepo()
async def work(_session: AsyncSession) -> dict[str, Any]:
raise AppError(ErrorCode.LLM_UNAVAILABLE, "Kimi 设备授权轮询超时")
await run_job(factory, JOB_ID, work, repo_factory=lambda _s: repo)
assert repo.status == STATUS_FAILED
assert repo.error == "LLM_UNAVAILABLE: Kimi 设备授权轮询超时"