写→审链新增第五审「人物塑造」(灵感③/D2):advisory 单维——仅建议、不阻断
验收(不进 conflicts、不碰 assert_conflicts_resolved、不入 REVIEW_RESERVED_NAMES);
只做人物塑造、不做氛围。
- SPEC characterization_spec(analyst,reads=("characters",),writes=())+
prompts/characterization.md(只读、显式忽略文本长度与辞藻华丽度、引用逐字片段+置信度)
- schema CharacterizationReview{issues[...]}(全字段默认值守解析韧性)+ 注册 catalog
- 计数三处 22→23 + regen prompt_hashes.json(仅加一条)
- DB chapter_reviews 加 characterization JSONB nullable 列(迁移 f6a7b8c9d0e1)
- 接线:graph REVIEW_SPECS 追加 · chain ReviewRecordRepo · collect(extract/record) ·
review_repo(Protocol/Sql/_to_view/ReviewView) · sse(event/factory/section) · normalize 自动纳入
- 契约 ReviewHistoryItem 加 characterization(gen:api 已重生成)
- 前端 sse/history/useReviewStream + CharacterizationPanel(只展示无裁决 UI、置信度降序+低置信折叠)+ ReviewReport 挂面板
- 测试 test_characterization_does_not_block_accept + 计数/golden + collect/normalize + 前端 reducer/normalize/parse
守不变量 #2/#3/#9;依赖 ⑧(motive/appearance 作客观锚点)。
109 lines
3.1 KiB
TypeScript
109 lines
3.1 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
|
|
import {
|
|
initialReviewState,
|
|
parseReviewBlock,
|
|
reduceReview,
|
|
type ReviewSseEvent,
|
|
} from "./sse";
|
|
|
|
const FULL_ISSUE = {
|
|
character: "沈砚",
|
|
aspect: "动机一致性",
|
|
where: "第3段",
|
|
quote: "他忽然转身。",
|
|
diagnosis: "动机断裂",
|
|
suggestion: "扣回护妹动机",
|
|
confidence: 0.82,
|
|
};
|
|
|
|
describe("parseReviewBlock — characterization (灵感③ advisory)", () => {
|
|
it("parses a characterization frame with a full issue", () => {
|
|
const evt = parseReviewBlock(
|
|
`event:characterization\ndata:{"issues":[${JSON.stringify(FULL_ISSUE)}]}`,
|
|
);
|
|
expect(evt).toEqual({
|
|
event: "characterization",
|
|
data: { issues: [FULL_ISSUE] },
|
|
});
|
|
});
|
|
|
|
it("defaults missing issue fields (advisory 韧性)", () => {
|
|
const evt = parseReviewBlock(
|
|
'event:characterization\ndata:{"issues":[{"character":"阿黎"}]}',
|
|
);
|
|
expect(evt).toEqual({
|
|
event: "characterization",
|
|
data: {
|
|
issues: [
|
|
{
|
|
character: "阿黎",
|
|
aspect: "",
|
|
where: "",
|
|
quote: "",
|
|
diagnosis: "",
|
|
suggestion: "",
|
|
confidence: 0,
|
|
},
|
|
],
|
|
},
|
|
});
|
|
});
|
|
|
|
it("parses an empty issues frame (无明显问题降级)", () => {
|
|
expect(
|
|
parseReviewBlock('event:characterization\ndata:{"issues":[]}'),
|
|
).toEqual({ event: "characterization", data: { issues: [] } });
|
|
});
|
|
|
|
it("drops non-record issues without dropping the whole frame", () => {
|
|
const evt = parseReviewBlock(
|
|
'event:characterization\ndata:{"issues":["junk",{"character":"沈砚"}]}',
|
|
);
|
|
expect(evt?.event).toBe("characterization");
|
|
if (evt?.event === "characterization") {
|
|
expect(evt.data.issues).toHaveLength(1);
|
|
expect(evt.data.issues[0]?.character).toBe("沈砚");
|
|
}
|
|
});
|
|
});
|
|
|
|
describe("reduceReview — characterization (replace-style like pace)", () => {
|
|
it("sets characterization report and marks reviewing", () => {
|
|
const evt: ReviewSseEvent = {
|
|
event: "characterization",
|
|
data: { issues: [FULL_ISSUE] },
|
|
};
|
|
const out = reduceReview(initialReviewState, evt);
|
|
expect(out.phase).toBe("reviewing");
|
|
expect(out.characterization).toEqual({ issues: [FULL_ISSUE] });
|
|
});
|
|
|
|
it("replaces (not accumulates) the characterization report", () => {
|
|
const first = reduceReview(initialReviewState, {
|
|
event: "characterization",
|
|
data: { issues: [FULL_ISSUE] },
|
|
});
|
|
const second = reduceReview(first, {
|
|
event: "characterization",
|
|
data: { issues: [] },
|
|
});
|
|
expect(second.characterization).toEqual({ issues: [] });
|
|
});
|
|
|
|
it("leaves characterization untouched on a section event", () => {
|
|
const seeded = reduceReview(initialReviewState, {
|
|
event: "characterization",
|
|
data: { issues: [FULL_ISSUE] },
|
|
});
|
|
const out = reduceReview(seeded, {
|
|
event: "section",
|
|
data: { name: "characterization", status: "done" },
|
|
});
|
|
expect(out.characterization).toEqual({ issues: [FULL_ISSUE] });
|
|
expect(out.sections).toEqual([
|
|
{ name: "characterization", status: "done" },
|
|
]);
|
|
});
|
|
});
|