1. `.gitignore` swallowed a source file. `agent/src/dist/buildBinary.ts` is the
packaging config, not build output, but the blanket `dist/` rule meant it was
never committed — a fresh clone could neither typecheck `agent/src/index.ts`
nor import it from the committed `agent/test/buildBinary.test.ts`. Re-included
the DIRECTORY first (git does not descend into an excluded one, so un-ignoring
just the file would not have worked) and committed the file. Verified build
output under `agent/dist/`, `dist/`, `public/build/` is still ignored.
2. Tunnel logs named no host. `pair` learned hostId/subdomain from the enroll
response and threw them away, so the long-running `run` process logged
`{"subdomain":null,"hostId":null}` — including all 6380 warnings during the
8-day outage, at exactly the moment you want to know which host. New
`config/hostRecord.ts` persists them at enrol; `resolveHostIdentity` resolves
config > record > the subdomain embedded in the leaf's SPIFFE SAN, so hosts
enrolled before the record existed get an identifier back without re-pairing.
3. The phone track had no recovery path. Added `POST /device/:id/recover`,
mirroring the host route: cert in the body, device-CA path validation, SPIFFE
parse, `notBefore` never graced, and the full registry check (active + same
account + `:id` matches the cert + same key) — only `notAfter` is relaxed.
Verified: agent 300/300, control-plane 296/296, tsc clean on both.
NOTE: the iOS/Android clients are not wired to call /device/:id/recover yet —
the server capability exists, the client-side trigger does not.
5.0 KiB
Enroll vhost addition — /recover (expired-leaf recovery)
One location block to merge into the existing enroll vhost on the VPS
(/etc/nginx/conf.d/enroll.conf, the 127.0.0.1:8471 server). No new server, no new SNI route, no
DNS work.
This is a MERGE, not a file to ship. The enroll vhost also carries
/enroll,/device/enroll,/auth/login,/crl/,/renewand/device/:id/renew— do not replace it.
Why the route exists
POST /renew is mTLS-authenticated by the very leaf it renews, so once that leaf lapses the host can
never renew it and the tunnel stays down until an operator re-pairs. That is not hypothetical: a
laptop slept through its 8h renewal window, its 24h leaf expired, and the agent then logged
client certificate has expired; renew before dialling 6380 times over 8 days without recovering.
Why it cannot be fixed on /renew itself
nginx will not forward an expired client certificate, under any ssl_verify_client mode.
optional→ nginx answers a bare400 The SSL certificate erroras soon as verification fails. The request never reaches thelocation, so noif ($ssl_client_verify …)can rescue it.optional_no_ca→ does not help either. It only tolerates chain failures; see nginx'sngx_ssl_verify_error_optional(), which coversDEPTH_ZERO_SELF_SIGNED_CERT,SELF_SIGNED_CERT_IN_CHAIN,UNABLE_TO_GET_ISSUER_CERT_LOCALLYandUNABLE_TO_VERIFY_LEAF_SIGNATURE— and notX509_V_ERR_CERT_HAS_EXPIRED.ssl_verify_clientis aserver-level directive, so it cannot be relaxed per-location anyway.
So recovery drops mTLS: /recover takes no client certificate, and the lapsed cert travels in
the request body instead.
Why that is still authenticated
A certificate is public, so the body alone proves nothing — possession of the private key does, and it is still proven end to end:
- the accompanying CSR is self-signed by that key, and the host signer's delegated gate enforces
CSR proof-of-possession plus
CSR key == registered key(control-plane/src/ca/csr.tsverifyCsrPoP); control-plane/src/api/renew.tsruns the same trust pipeline as/renew— real X.509 path validation to the frp-client-CA anchors, SPIFFE SAN parse,notBefore, and a registry lookup requiring anactive, account-consistent host — differing only in a bounded overrun allowance onnotAfter(DEFAULT_EXPIRED_RENEW_GRACE_MS, 30 days).
Worst case for a replayed cert without the key: the attacker receives a certificate they cannot authenticate with. Revocation still bites, via registry status.
The blocks to add
Two routes, same rationale: /recover re-issues an expired host frp-client leaf,
/device/:id/recover does the same for an expired device cert (phone track).
# Expired-leaf recovery: NO client cert (see enroll-recover-location.md). The control-plane is
# the sole verifier; strip any client-supplied cert header so only the body can speak.
location = /recover {
limit_req zone=renew_recover burst=5 nodelay;
proxy_pass http://127.0.0.1:8080;
proxy_http_version 1.1;
proxy_set_header Host $host;
proxy_set_header x-client-cert "";
proxy_read_timeout 60s;
}
# Same, for an expired DEVICE cert. Must sit ABOVE the `~ ^/device/[^/]+/renew$` mTLS location
# only if that regex could also match `/recover` — it cannot, but keep them adjacent so the pair
# is obvious to the next editor.
location ~ ^/device/[^/]+/recover$ {
limit_req zone=renew_recover burst=5 nodelay;
proxy_pass http://127.0.0.1:8080;
proxy_http_version 1.1;
proxy_set_header Host $host;
proxy_set_header x-client-cert "";
proxy_read_timeout 60s;
}
And once, in the http context (top of enroll.conf is fine) — the route is reachable
pre-authentication and costs the control-plane an X.509 path validation, so bound it. The
control-plane additionally rate-limits per identity (createRenewRateLimiter, 30/hour):
limit_req_zone $binary_remote_addr zone=renew_recover:1m rate=10r/m;
Deploy gate
cp /etc/nginx/conf.d/enroll.conf{,.bak.$(date +%s)} # snapshot first
# ...merge the block above...
nginx -t && systemctl restart nginx # NEVER reload on a failed -t
restart, not reload: a graceful reload has been observed keeping old workers alive for seconds,
which makes post-deploy verification race the change.
Verify
# no cert needed — an in-grace expired leaf is re-issued
curl -sS --resolve enroll.terminal.yaojia.wang:443:<vps> \
-X POST -H 'content-type: application/json' \
-d "{\"cert\":\"$(base64 -w0 expired.cert.pem)\",\"csr\":\"$(base64 -w0 new.csr.der)\"}" \
https://enroll.terminal.yaojia.wang/recover # → 201 {cert,caChain,notAfter}
# a forged self-signed cert with a correct-looking SPIFFE SAN must still be refused
# → 401 (this is the load-bearing check; nginx is no longer validating the chain here)